Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine writes in WidenAsciiToUtf16 #88502

Closed
wants to merge 15 commits into from
Closed

Combine writes in WidenAsciiToUtf16 #88502

wants to merge 15 commits into from

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 7, 2023 •
edited
Loading

TODO: Check logic for big-endian.

Indicative codegen on ARM64 when widening ushort to uint.

;bc76418
            orr     w0, w3, w3,  LSL #8
            and     w0, w0, #0xD1FFAB1E
            ubfiz   x2, x2, #1, #32
            str     w0, [x1, x2]
						;; size=16 bbWeight=1 PerfScore 3.50
;base
            lsl     x0, x2, #1
            uxtb    w2, w3
            strh    w2, [x1, x0]
            uxth    w2, w3
            asr     w2, w2, #8
            add     x0, x1, x0
            strh    w2, [x0, #0x02]
						;; size=28 bbWeight=1 PerfScore 5.50

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 7, 2023
@ghost
Copy link

ghost commented Jul 7, 2023

Tagging subscribers to this area: @dotnet/area-system-text-encoding
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: xtqqczze
Assignees: -
Labels:

area-System.Text.Encoding, community-contribution
Milestone: -

@xtqqczze xtqqczze changed the title Optimization to WidenAsciiToUtf16 Combine stores in WidenAsciiToUtf16 Jul 7, 2023
@xtqqczze xtqqczze changed the title Combine stores in WidenAsciiToUtf16 Combine writes in WidenAsciiToUtf16 Jul 7, 2023
This was referenced Jul 7, 2023
Closed
Closed
Closed
@runfoapp runfoapp bot mentioned this pull request Jul 7, 2023
Closed
@xtqqczze xtqqczze closed this Jul 7, 2023
@xtqqczze xtqqczze reopened this Jul 7, 2023
@build-analysis build-analysis bot mentioned this pull request Jul 7, 2023
Closed
@xtqqczze xtqqczze marked this pull request as ready for review July 7, 2023 23:34
@xtqqczze xtqqczze marked this pull request as draft July 8, 2023 15:48
This was referenced Jul 8, 2023
Closed
Closed
@xtqqczze
Copy link
Contributor Author

/azp run runtime-community

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 88502 in repo dotnet/runtime

@xtqqczze
Copy link
Contributor Author

@stephentoub Can we run checks on big-endian hardware?

@stephentoub
Copy link
Member

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@stephentoub
Copy link
Member

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jul 17, 2023
Closed
@xtqqczze
Copy link
Contributor Author

/azp run runtime-community

@stephentoub

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 88502 in repo dotnet/runtime

@build-analysis build-analysis bot mentioned this pull request Jul 17, 2023
Closed
@xtqqczze
Copy link
Contributor Author

@stephentoub I think the runtime failures are unrelated. They appear to be linked to XUnitWrapperGenerator.

@xtqqczze
Copy link
Contributor Author

@stephentoub Could you please run runtime-community again.

@ghost ghost closed this Aug 20, 2023
@ghost
Copy link

ghost commented Aug 20, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 20, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-System.Text.Encoding community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xtqqczze @stephentoub